Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[BaseKit.com] Remove broken targets - #10087

Merged
J0WI merged 5 commits into
EFForg:masterfrom
Bisaloo:patch-8
Jul 30, 2017
Merged

J0WI merged 5 commits into
EFForg:masterfrom
Bisaloo:patch-8

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Jun 1, 2017

Copy link
Copy Markdown
Collaborator

I'm not entirely sure what to do here. I usually wouldn't use https-everywhere to fix broken websites but it was already here so...


Invalid certificate:
basekit.com
custom-css.basekit.com

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an active target

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see the rewrite rule.

<target host="custom-css.basekit.com" />
<target host="resources.basekit.com" />

<target host="try.basekit.com" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also:

support.basekit.com
apidocs.basekit.com
knowledge.basekit.com
docs.basekit.com
partners.basekit.com
trivia.basekit.com

It seems that customers get a subdomain (which works over HTTPS), so this rule may need a wildcard.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that customers get a subdomain (which works over HTTPS), so this rule may need a wildcard.

Some of them may have mixed content issues (for example https://odense.basekit.com/). Should I still add a wildcard with exclusion and hope it doesn't break too many customers subdomains?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand this host is a website builder. It's unlikely that there are major differences between all the sites or customers are allowed to insert active content. In this example only Google Fonts are affected.
Let's add the wildcard.

@J0WI
J0WI merged commit 9eff493 into EFForg:master Jul 30, 2017
luciancor pushed a commit to luciancor/https-everywhere that referenced this pull request Aug 24, 2017
* [BaseKit.com] Remove broken targets

* [Basekit.com] Trivialize securecookie

* [Basekit.com] Add subdomains

* [Basekit.com] Add wildcard

* [Basekit.com] Add exclusion add test urls
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants